Öne çıkan içerik

Remove FTXUI and its console input (#772) Command input is now available exclusively through Telnet server support, which was introduced by #770. Github Commit Görüntüle... See Commints... ..

fix: Set debug-build flags in CMake builds (#771) We expect _DEBUG & DEBUG to exist in our codebase, but CMake doesn't automatically set these. The only thing it sets is NDEBUG. To ensure everything continues to behave as intended in the codebase, we restore _DEBUG & DEBUG. Github Commit Görüntüle... See Commints... ..

feat: Add Telnet connections to server programs (#770) * feature/telnet-commands: Add Telnet connections to server programs for health checks and general command input --------- Co-authored-by: twostars <i.am.twostars@gmail.com> Github Commit Görüntüle... See Commints... ..

Implement CHECK_STAT_TOTAL and CHECK_SKILL_TOTAL (#769) * Implement CHECK_STAT_TOTAL and CHECK_SKILL_TOTAL Github Commit Görüntüle... See Commints... ..

ci: clang-tidy tweaks (#767) * In our fork of cpp-linter / cpp-linter-action, we add --clang-tidy-extensions (script) / clang-tidy-extensions (action setting). This is effectively used for clang-tidy to include all changed files for analysis (i.e. inclusive of headers), while still only directly processing the main source files that were changed. The big caveat here is that for this to actually report headers, a source file that includes it at some point must also be changed. * For...

Server: Only warn on pointer arithmetic (#766) * Server: Only warn on pointer arithmetic This is used by its packet handling, so it shouldn't error as-is. * Use our fork of cpp-linter-action so that we can only fail on errors, not warnings. Github Commit Görüntüle... See Commints... ..

ci: Add clang-tidy workflow (#739) * Add clang-tidy workflow. Will fail and annotate files over on a PR's "Files" page. --------- Co-authored-by: twostars <i.am.twostars@gmail.com> Github Commit Görüntüle... See Commints... ..

Auto-cancel old GitHub workflows (#763) * Auto-cancel old GitHub workflows Github Commit Görüntüle... See Commints... ..

CMake: Use Ninja for Windows/MSVC builds (#762) The MSVC generator is very limited and doesn't support a lot of the global options. Ninja is a safer more consistent choice, and will still use MSVC underneath (with the build environment setup). Unfortunately, the mixed Unicode/MultiByte usage confuses the Ninja builds. As such, we will keep the codebase consistently MultiByte as it makes up the core of the codebase, and the codebase is moving away from Windows anyway. Github Commit...

build: Minor tweaks and fixes (#761) * Server.slnx: Ensure fetch-argparse depends on sync-submodules for the base lock * ThirdParty.slnx: Add fetch-argparse here just to pre-emptively fetch it and not pollute build times. Ordinarily we add things here to have them excluded by CodeQL's scan, but this is header-only so it doesn't really matter here -- the only thing it's doing is inflating the build time associated with the server when it fetches the repo within the workflow. *...

CMake: Expose server project include paths for tests (#760) Github Commit Görüntüle... See Commints... ..

Minor tweaks to faciliate app tests (#759) * Minor tweaks to faciliate app tests * Tweak socket manager shutdown logic to avoid the worker thread pointer being accessed twice. This doesn't happen in regular server uses; only when it's not actually setup and using the socket manager, but we should play it safe regardless. * Tweak sockets to allow us to default initialize (as-is, an asio socket requires an executor to be constructed, which we don't want to use). * Tweak exposed...

Rename projects from *-tests to *.Tests for consistency (#758) * Rename projects from *-tests to *.Tests for consistency * Reset test projects to C++20 Github Commit Görüntüle... See Commints... ..

Reset server projects back to C++20 (#757) * Reset server projects back to C++20 The server projects were on C++23 because we needed C++23's extended modules support (the BMI paths). We don't use modules anymore for greater compatibility, so we don't need to be on C++23. Additionally, clang-tidy does not like C++23 (at least, not via stdcpp23 -- CMake uses stdcpplatest which is vaguer but it may pass that through), so we'll just consistently drop everything back to C++20. * Include the...

Update <inttypes.h>/<stdint.h> to <cinttypes>/<cstdint> (#756) These are deprecated. Github Commit Görüntüle... See Commints... ..

Separate projects for tests (#755) * CMake: Separate server & client projects to lib/exe * VS: Add separate projects Also group them to be slightly less obnoxious. * Move the server projects into unique namespaces This helps avoid clashes between names (particularly with things like CUser, or common constants). * Rename lib* to project.Core This helps sort it in the IDE to be slightly less of an inconvenience. Github Commit Görüntüle... See Commints... ..

SqlBuilder: Fix WHERE clause when explicitly specified (#753) Github Commit Görüntüle... See Commints... ..

Fix snow on device reset (#752) Also avoid using D3DLOCK_NOSYSLOCK and fix the error code reported on a failed reset. Github Commit Görüntüle... See Commints... ..

AI server: Enable NPC to NPC hostility (#751) In the original code, this entire section was bugged. It inadvertently defined 2 vars for the monster count; 1 in scope, and 1 out. This means that it was previously NEVER hostile towards any other NPCs. This of course isn't official behaviour; they had fixed it by (at least) 1.298. Github Commit Görüntüle... See Commints... ..

Client & server: Address common clang-tidy warnings (#744) * Address many common clang-tidy warnings in client & server projects * Disable NPC<->NPC hostility temporarily to replicate previous behaviour which was only disabled due to an official bug Github Commit Görüntüle... See Commints... ..