T
twostars
Minor tweaks to faciliate app tests (#759)
* Minor tweaks to faciliate app tests
* Tweak socket manager shutdown logic to avoid the worker thread pointer being accessed twice.
This doesn't happen in regular server uses; only when it's not actually setup and using the socket manager, but we should play it safe regardless.
* Tweak sockets to allow us to default initialize (as-is, an asio socket requires an executor to be constructed, which we don't want to use).
* Tweak exposed constexpr vars in the headers; these should be inline so as to cause the same var to be reused across translation units.
* Existing tests should also just use <ctime> not <time.h> as time.h is deprecated.
Github Commit Görüntüle...
See Commints...
..
* Minor tweaks to faciliate app tests
* Tweak socket manager shutdown logic to avoid the worker thread pointer being accessed twice.
This doesn't happen in regular server uses; only when it's not actually setup and using the socket manager, but we should play it safe regardless.
* Tweak sockets to allow us to default initialize (as-is, an asio socket requires an executor to be constructed, which we don't want to use).
* Tweak exposed constexpr vars in the headers; these should be inline so as to cause the same var to be reused across translation units.
* Existing tests should also just use <ctime> not <time.h> as time.h is deprecated.
Github Commit Görüntüle...
See Commints...
..