T
twostars
Refactor CUICmdList (#594)
* Refactor CUICmdList
* Avoid spamming resource lookups with wonky list scans; just be explicit about what we're after, by using explicit category list ranges. This ensures behaviour is very obvious and predictable and avoids a bunch of log spam:
[23:54:09] get_from_texts(9596) failed - resource missing in Texts TBL.
[23:54:09] get_from_texts(9597) failed - resource missing in Texts TBL.
[23:54:09] get_from_texts(9598) failed - resource missing in Texts TBL.
[23:54:09] get_from_texts(9599) failed - resource missing in Texts TBL.
* Extend e_ChatCmd for King and Guardian Monster categories. Move to UICmdList.h, as we'll need to be refactoring all of this soon.
Officially they move all of this logic directly into CUICmdList and categorise it, which once done will simplify our logic considerably.
* Reuse g_szCmdMsg (formerly s_szCmdMsg, though it'll probably get renamed back again when properly shifted) for command name lookups in CUICmdList.
Since they're loaded already, we don't really need to load them again.
* Remove hardcoded "PM" command name check; test with the loaded command index instead (CMD_WHISPER).
* To better allow for the GM command category check (which is unofficial; the GM command category is not displayed by this UI officially), load the category data only on handling WIZ_MYINFO, i.e. when we know that we're a GM.
* Additionally, rename m_pUICmdListDlg -> m_pUICmdList & m_pUICmdEditDlg -> m_pUICmdEdit.
Github Commit Görüntüle...
See Commints...
..
* Refactor CUICmdList
* Avoid spamming resource lookups with wonky list scans; just be explicit about what we're after, by using explicit category list ranges. This ensures behaviour is very obvious and predictable and avoids a bunch of log spam:
[23:54:09] get_from_texts(9596) failed - resource missing in Texts TBL.
[23:54:09] get_from_texts(9597) failed - resource missing in Texts TBL.
[23:54:09] get_from_texts(9598) failed - resource missing in Texts TBL.
[23:54:09] get_from_texts(9599) failed - resource missing in Texts TBL.
* Extend e_ChatCmd for King and Guardian Monster categories. Move to UICmdList.h, as we'll need to be refactoring all of this soon.
Officially they move all of this logic directly into CUICmdList and categorise it, which once done will simplify our logic considerably.
* Reuse g_szCmdMsg (formerly s_szCmdMsg, though it'll probably get renamed back again when properly shifted) for command name lookups in CUICmdList.
Since they're loaded already, we don't really need to load them again.
* Remove hardcoded "PM" command name check; test with the loaded command index instead (CMD_WHISPER).
* To better allow for the GM command category check (which is unofficial; the GM command category is not displayed by this UI officially), load the category data only on handling WIZ_MYINFO, i.e. when we know that we're a GM.
* Additionally, rename m_pUICmdListDlg -> m_pUICmdList & m_pUICmdEditDlg -> m_pUICmdEdit.
Github Commit Görüntüle...
See Commints...
..