T
twostars
Replace libjpeg-turbo with IJG's libjpeg (#795)
* Replace libjpeg-turbo with IJG's libjpeg
libjpeg-turbo is a bad fit as a CMake dependency.
It requires the use of ExternalProject_Add() which creates complications,
particularly when swapping the compiler (e.g. for mingw), not to mention
as-is, it ends up having to fetch at build time rather than configure time
like every other dependency.
As we only use this for screenshots (KSCs) (i.e. its use is limited to the
KscViewer and the very rare instance of pressing the in-game screenshot button),
the performance benefit of libjpeg-turbo is fairly moot.
For simplicity, we go back to the basic IJG implementation (with unofficially
added CMake config).
This allows us to use the dependency directly and consistently with the others,
and there's no concern with it using a different compiler unintentionally.
* clang-tidy-check.yml doesn't need hacks anymore
Github Commit Görüntüle...
See Commints...
..
* Replace libjpeg-turbo with IJG's libjpeg
libjpeg-turbo is a bad fit as a CMake dependency.
It requires the use of ExternalProject_Add() which creates complications,
particularly when swapping the compiler (e.g. for mingw), not to mention
as-is, it ends up having to fetch at build time rather than configure time
like every other dependency.
As we only use this for screenshots (KSCs) (i.e. its use is limited to the
KscViewer and the very rare instance of pressing the in-game screenshot button),
the performance benefit of libjpeg-turbo is fairly moot.
For simplicity, we go back to the basic IJG implementation (with unofficially
added CMake config).
This allows us to use the dependency directly and consistently with the others,
and there's no concern with it using a different compiler unintentionally.
* clang-tidy-check.yml doesn't need hacks anymore
Github Commit Görüntüle...
See Commints...
..