Öne çıkan içerik

Merge pull request #603 from Open-KO/n3me-fix-shutdown-behaviour N3ME: Fix shutdown behaviour Github Commit Görüntüle... See Commints... ..

N3ME: Fix shutdown behaviour Shutdown shouldn't be invoking Release() here, in some cases twice. Release() tends to reset, which can involve UI operations which may not be valid at this point. We should just explicitly free instead. Github Commit Görüntüle... See Commints... ..

Re-encode resource files (.rc) as UTF8 (#602) Some systems can get confused when preemptively loading them as ANSI, even though they intend to load each section with their appropriate encoding. Adding the UTF8 BOM and letting MSVC re-encode by itself fixes this and ensures they load as intended. Github Commit Görüntüle... See Commints... ..

Implement LOGIC_CHECK_EMPTY_SLOT (#600) * Implement LOGIC_CHECK_EMPTY_SLOT * Resolve Review comments * Formatted the code * used a const reference instead of a copy of _ITEM_DATA * Minor reformatting --------- Co-authored-by: twostars <i.am.twostars@gmail.com> Github Commit Görüntüle... See Commints... ..

Re-encode resource files (.rc) as UTF8 Some systems can get confused when preemptively loading them as ANSI, even though they intend to load each section with their appropriate encoding. Adding the UTF8 BOM and letting MSVC re-encode by itself fixes this and ensures they load as intended. Github Commit Görüntüle... See Commints... ..

Merge pull request #601 from Open-KO/server-BOOL-to-bool Server: Use C++ bool instead of WinAPI-specific BOOL Github Commit Görüntüle... See Commints... ..

Server: Use C++ bool instead of WinAPI-specific BOOL Refs #472 Github Commit Görüntüle... See Commints... ..

Implement CHECK_CLAN_GRADE (#599) * Implement CHECK_CLAN_GRADE * Added implementation for checking the clan grade * Use c++ native bool and replace short with int Github Commit Görüntüle... See Commints... ..

Merge pull request #598 from Open-KO/simplify-evt-parsing Simplify EVT parsing by cutting out redundant arg parsing Github Commit Görüntüle... See Commints... ..

Simplify EVT parsing by cutting out redundant arg parsing Continue to parse the intended number of arguments to preserve behaviour, though this is just a nicety for now - I don't think there's really any reason we couldn't just attempt to parse all <max> args, regardless of whether they're used or not. Github Commit Görüntüle... See Commints... ..

Merge pull request #597 from Open-KO/log-evt-parsing Log unhandled EVT opcodes Github Commit Görüntüle... See Commints... ..

Log unhandled EVT opcodes Also be sure to parse via switch for efficiency and to avoid duplicate cases. Github Commit Görüntüle... See Commints... ..

Implement more LOGIC_ELSE EVT parsing (#508) * Implement more LOGIC_ELSE EVT parsing -CHECK_PROMOTION_ELIGIBLE -CHECK_MONSTER_CHALLENGE_TIME -CHECK_PPCARD_SERIAL -CHECK_NOEXIST_ITEM -CHECK_EXIST_EVENT -CHECK_ITEMCHANGE_NUM -CHECK_NOCLASS -CHECK_LOYALTY * Implemented the missing parsing of evts LOGIC_ELSE * Fix setting the correct m_LogicElse * Changesafter review * Added #ifdef for not implemented Checks * Added comments * Changesafter review * Added #ifdef for not implemented Checks...

Merge pull request #595 from Open-KO/remove-allsaveroutine-log-spam CAujardDlg::AllSaveRoutine() doesn't need to log unused slots Github Commit Görüntüle... See Commints... ..

CAujardDlg::AllSaveRoutine() doesn't need to log unused slots It can continue to log on actual issues (if for some reason the instance doesn't exist -- which shouldn't happen), but for conventional cases where nobody's simply using that slot at the moment, there's no real need for the log. This considerably reduces unnecessary log spam. Github Commit Görüntüle... See Commints... ..

Refactor CUICmdList (#594) * Refactor CUICmdList * Avoid spamming resource lookups with wonky list scans; just be explicit about what we're after, by using explicit category list ranges. This ensures behaviour is very obvious and predictable and avoids a bunch of log spam: [23:54:09] get_from_texts(9596) failed - resource missing in Texts TBL. [23:54:09] get_from_texts(9597) failed - resource missing in Texts TBL. [23:54:09] get_from_texts(9598) failed - resource missing in...

Merge pull request #593 from Open-KO/update-checkitemcount Server: Update CUser::CheckItemCount() Github Commit Görüntüle... See Commints... ..

Server: Update CUser::CheckItemCount() While it may appear a little wonky, this is official behaviour. The main important change here is if the minimum required count is 0, we typically consider it as successful (so long as it's a valid item). This fixes the final issue preventing Abyss teleport gates from initially triggering their menus. Resolves #500 Github Commit Görüntüle... See Commints... ..

Merge pull request #592 from Open-KO/fix-howmuch-item Fix HOWMUCH_ITEM's args Github Commit Görüntüle... See Commints... ..

HOWMUCH_ITEM has 3 args - the first is the item ID Refs #500 Github Commit Görüntüle... See Commints... ..